Skip to content

added initial solution #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vkryvytskyi wants to merge 18 commits into
base: master
Choose a base branch
from
Open

added initial solution #2676

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
efa2ecd
added initial solution
Apr 3, 2024
a946d53
solution 2
Apr 4, 2024
6831bb9
solution 3
Apr 5, 2024
0c9c947
solution 4
Apr 5, 2024
b67f7e2
solution 5
Apr 5, 2024
66f7d93
solution 6
Apr 8, 2024
412eb24
solution 7
Apr 8, 2024
2c949bd
solution 8
Apr 8, 2024
07d32d3
solution 9
Apr 8, 2024
727503c
solution 10
Apr 8, 2024
a44140d
solution 9.2
Apr 9, 2024
6320c61
solution 8.2
Apr 9, 2024
b589d37
top solution
Apr 15, 2024
408ab78
top solution fixed
Apr 15, 2024
fc864ed
top solution fixed 2
Apr 15, 2024
297f3ed
top solution fixed 3
Apr 15, 2024
c1b5609
top solution fixed 4
Apr 15, 2024
0d59f06
new solution
Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/inverseRobot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,18 @@
*/

function inverseRobot(robot) {
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to add a function description using JSDoc comments. This helps other developers understand what the function does, its parameters, and its return value.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to add a brief comment describing what your function does. This will help other developers understand your code more easily.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a check to ensure that the 'robot' parameter is indeed an object and not null or undefined. This can prevent potential runtime errors if the function is called with invalid arguments.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function 'inverseRobot' is correctly named and describes its purpose well.

// write code here
const clone = {};
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'clone' could be more descriptive. Consider renaming it to 'invertedRobot' or something similar to reflect its purpose of storing the inverted key-value pairs.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'clone' could be more descriptive. Consider renaming it to 'invertedRobot' or something similar to reflect its purpose of storing the inverted key-value pairs of the 'robot' object.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'clone' could be more descriptive. Consider renaming it to 'invertedRobot' to better reflect its purpose as the inverse of the input 'robot'.


for (const key in robot) {
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to use Object.keys() or Object.entries() to iterate over an object. This way, you don't have to worry about properties that come from the object's prototype.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using Object.keys(robot) or Object.entries(robot) to iterate over the properties of the robot object. This approach avoids iterating over properties in the prototype chain and is generally considered a best practice when you only want to deal with the object's own properties.

const newKey = robot[key];

if (clone.hasOwnProperty(newKey)) {
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using 'hasOwnProperty', which is an older approach, you can use the 'in' operator or 'Object.prototype.hasOwnProperty.call' for checking property existence to avoid issues with properties that may shadow object's own properties.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using 'Object.prototype.hasOwnProperty.call(clone, newKey)' instead of 'clone.hasOwnProperty(newKey)' to avoid issues that may arise if the object has a property with the name 'hasOwnProperty'. This is a more robust way to check for property existence.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method 'hasOwnProperty' is a safe way to check for property existence, but it's recommended to use 'Object.prototype.hasOwnProperty.call(clone, newKey)' to avoid issues in cases where the object might have a property with the name 'hasOwnProperty'.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using 'hasOwnProperty', it's recommended to use 'Object.prototype.hasOwnProperty.call' to avoid issues if the 'clone' object has a property with the name 'hasOwnProperty'.

return null;
}
clone[newKey] = key;
Comment on lines +12 to +18
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good practice to check if the property belongs to the object itself and is not inherited from the prototype chain. You can add a check using 'robot.hasOwnProperty(key)' inside the loop.

}
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InversedRobot, use inversedRobot instead of robot.


return clone;
}

module.exports = inverseRobot;
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good practice to include a newline at the end of the file. Some tools and systems expect or require it for proper processing.