Skip to content

added initial solution #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vkryvytskyi wants to merge 18 commits into
base: master
Choose a base branch
from
Open

added initial solution #2676

Changes from 17 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
efa2ecd
added initial solution
Apr 3, 2024
a946d53
solution 2
Apr 4, 2024
6831bb9
solution 3
Apr 5, 2024
0c9c947
solution 4
Apr 5, 2024
b67f7e2
solution 5
Apr 5, 2024
66f7d93
solution 6
Apr 8, 2024
412eb24
solution 7
Apr 8, 2024
2c949bd
solution 8
Apr 8, 2024
07d32d3
solution 9
Apr 8, 2024
727503c
solution 10
Apr 8, 2024
a44140d
solution 9.2
Apr 9, 2024
6320c61
solution 8.2
Apr 9, 2024
b589d37
top solution
Apr 15, 2024
408ab78
top solution fixed
Apr 15, 2024
fc864ed
top solution fixed 2
Apr 15, 2024
297f3ed
top solution fixed 3
Apr 15, 2024
c1b5609
top solution fixed 4
Apr 15, 2024
0d59f06
new solution
Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/inverseRobot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,17 @@
*/

function inverseRobot(robot) {
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to add a function description using JSDoc comments. This helps other developers understand what the function does, its parameters, and its return value.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to add a brief comment describing what your function does. This will help other developers understand your code more easily.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a check to ensure that the 'robot' parameter is indeed an object and not null or undefined. This can prevent potential runtime errors if the function is called with invalid arguments.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function 'inverseRobot' is correctly named and describes its purpose well.

// write code here
const invertedRobot = {};

for (const key in robot) {
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to use Object.keys() or Object.entries() to iterate over an object. This way, you don't have to worry about properties that come from the object's prototype.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using Object.keys(robot) or Object.entries(robot) to iterate over the properties of the robot object. This approach avoids iterating over properties in the prototype chain and is generally considered a best practice when you only want to deal with the object's own properties.

if (robot[key] in invertedRobot) {
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for property presence is correct, but it's worth noting that using 'in' will check the entire prototype chain. If you want to check only the object's own properties, use 'robot.hasOwnProperty(key)'.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for property presence should be done using Object.hasOwnProperty() method to avoid issues with inherited properties. Directly using in might lead to unexpected behavior if the object has inherited properties with the same name as the values you are checking.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to explicitly compare the property to 'undefined' to check for its existence. This makes the intention clearer and the code more readable.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check robot[key] in invertedRobot is using the in operator, which checks for the presence of a key in an object. However, since robot[key] is a value and not a key, you should use hasOwnProperty to check if the value already exists as a key in invertedRobot.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check robot[key] in invertedRobot is correct for determining if a property exists in an object. However, it's worth noting that using in will also return true for inherited properties. To ensure that only own properties are considered, you might want to use Object.prototype.hasOwnProperty.call(invertedRobot, robot[key]) or invertedRobot.hasOwnProperty(robot[key]).

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to use 'hasOwnProperty' method to check for property existence to avoid issues with properties from the prototype chain. Consider using 'invertedRobot.hasOwnProperty(robot[key])' instead of 'robot[key] in invertedRobot'.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check robot[key] in invertedRobot is correct for determining if a property exists in an object. However, it's important to note that using in will also return true for inherited properties. To ensure that only own properties are considered, you might want to use Object.prototype.hasOwnProperty.call(invertedRobot, robot[key]) or invertedRobot.hasOwnProperty(robot[key]).

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check robot[key] in invertedRobot is correct for determining if a property exists in an object. However, it's important to remember that using in will also return true for inherited properties. To ensure that only own properties are considered, you might want to use Object.prototype.hasOwnProperty.call(invertedRobot, robot[key]) or invertedRobot.hasOwnProperty(robot[key]).

return null;
}

invertedRobot[robot[key]] = key;
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When assigning the key as the value and the value as the key, it's important to ensure that the value is actually a string that can be used as a property name. If the value is not a string (e.g., a number, an object, etc.), it should be converted to a string to maintain the integrity of the object structure.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to convert the key to a string before using it as a property name to ensure that the object keys are consistent, especially when dealing with non-string properties.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using 'Object.hasOwnProperty()' to check if the property exists on 'invertedRobot'. Directly using 'in' might lead to unexpected results if the object has inherited properties.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When assigning key to invertedRobot[robot[key]], ensure that you are storing the original key as a string. If the key is a number, it will be coerced into a string, which might not be intended. If you want to preserve the type, you might need to handle it differently.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When assigning the key to the invertedRobot, it's a good practice to ensure that the value is a valid identifier or use bracket notation. Since the value of robot[key] is used as a property name, if it's not a valid identifier (e.g., a number, a string with spaces, etc.), it should be enclosed in quotes when used with dot notation. In this case, you are using bracket notation which is correct and handles all cases.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When assigning the key to the invertedRobot, it's safer to ensure that the key is a string. Since object keys are always strings, if the value is not a string, it could lead to unexpected behavior. Use 'String(key)' to convert it explicitly.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When assigning the key to the invertedRobot, it's a good practice to ensure that the value is a string since object keys in JavaScript are always strings or symbols. If the key is not a string, it will be coerced to a string, which could lead to unexpected behavior if the key is, for example, a number. You can use String(key) to explicitly convert it to a string.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When assigning the key to the value in invertedRobot, it's a good practice to ensure that the value is a string, as object keys are always strings in JavaScript. If the original key in the robot object is not a string (e.g., a number), it will be coerced to a string when used as a key in invertedRobot. If this behavior is intended, then the code is correct. Otherwise, consider converting the key to a string explicitly if needed.

}
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InversedRobot, use inversedRobot instead of robot.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to avoid using nested for loops

Comment on lines +12 to +19
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using 'Object.hasOwnProperty()' to check if a property exists on an object. While using 'in' is not incorrect, 'hasOwnProperty()' does not check down the object's prototype chain, which can be safer for property existence checks.


return invertedRobot;
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function correctly returns the 'invertedRobot' object if no duplicate values are found in the input 'robot' object.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning the invertedRobot object is correct. The function will return either null if a duplicate value is found or the inverted object otherwise, adhering to the task requirements.

}
Comment on lines 9 to 22
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function inverseRobot is doing more work than necessary. It first checks for duplicate values in the input object by comparing each value with every other value. This results in a time complexity of O(n^2), which is not efficient for large inputs. Then it creates the inverse object. These two steps can be combined into one, which would result in a time complexity of O(n).


module.exports = inverseRobot;
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good practice to include a newline at the end of the file. Some tools and systems expect or require it for proper processing.