OOP Basic - #2621
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution meets all functional requirements correctly. The abstract Machine class, inheritance hierarchy with Truck, Bulldozer, and Excavator, polymorphic Machine[] array in MainApp, and overridden methods with English messages are all properly implemented. The only issues are minor style violations—redundant empty lines between declarations and missing trailing newlines at file endings—which are handled by the linter. The code compiles and runs correctly with all required functionality in place.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| public class Bulldozer extends Machine { | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: redundant empty line after package declaration
There was a problem hiding this comment.
Please explain exactly what is wrong.
|
|
||
| public class Bulldozer extends Machine { | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: redundant empty line after package declaration
There was a problem hiding this comment.
Please explain exactly what is wrong.
|
|
||
| public class Bulldozer extends Machine { | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: redundant empty line after package declaration
There was a problem hiding this comment.
Please explain exactly what is wrong.
| package core.basesyntax; | ||
|
|
||
| public abstract class Machine { | ||
|
|
||
| public abstract void doWork(); | ||
|
|
||
| public abstract void stopWork(); | ||
| } No newline at end of file |
There was a problem hiding this comment.
This violates checklist item #1: redundant empty lines appear after package declaration (line 2), after class declaration (line 4), and after method signature (line 6). Compare with the improved example in the checklist that has no empty lines after class declaration or method signature.
| package core.basesyntax; | ||
|
|
||
| public abstract class Machine { | ||
|
|
||
| public abstract void doWork(); | ||
|
|
||
| public abstract void stopWork(); | ||
| } No newline at end of file |
There was a problem hiding this comment.
This violates checklist item #1: redundant empty lines appear after package declaration (line 2), after class declaration (line 4), and after method signature (line 6). Compare with the improved example in the checklist that has no empty lines after class declaration or method signature.
| package core.basesyntax; | ||
|
|
||
| public abstract class Machine { | ||
|
|
||
| public abstract void doWork(); | ||
|
|
||
| public abstract void stopWork(); | ||
| } No newline at end of file |
There was a problem hiding this comment.
This violates checklist item #1: redundant empty line appears after package declaration (line 2), after class declaration (line 4), and between abstract methods (line 6). Compare with the improved example in the checklist that has no empty lines after class declaration or method signature.
|
|
||
| public class Truck extends Machine { | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: redundant empty line after package declaration. Compare with the improved example in the checklist - no empty lines should appear after class declaration or method signature.
| package core.basesyntax; | ||
|
|
||
| public class Truck extends Machine { | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: redundant empty line after class declaration. The checklist shows this as a bad pattern that should be avoided.
| } | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: redundant empty line after method signature (line 6). The checklist specifically warns against empty lines after method signatures.
There was a problem hiding this comment.
Please explain exactly what is wrong.
There was a problem hiding this comment.
Please explain exactly what is wrong.
There was a problem hiding this comment.
Please explain exactly what is wrong.
|
|
||
| public class Bulldozer extends Machine { | ||
|
|
There was a problem hiding this comment.
Please explain exactly what is wrong.
|
|
||
| public class Bulldozer extends Machine { | ||
|
|
There was a problem hiding this comment.
Please explain exactly what is wrong.
|
|
||
| public class Bulldozer extends Machine { | ||
|
|
There was a problem hiding this comment.
Please explain exactly what is wrong.
2 participants
No description provided.