Skip to content

add forms #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnnBusya wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add forms #783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dce3d6e
add forms
AnnBusya Apr 26, 2023
fc3fca0
fixed label-radio and add name-textarea
AnnBusya Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# HTML form
Replace `<your_account>` with your Github username and copy the links to Pull Request description:
- [DEMO LINK](https://<your_account>.github.io/layout_html-form/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_html-form/report/html_report/)
- [DEMO LINK](https://AnnBusya.github.io/layout_html-form/)
- [TEST REPORT LINK](https://AnnBusya.github.io/layout_html-form/report/html_report/)

> Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/#how-to-solve-the-layout-tasks-on-github)
___
Expand Down Expand Up @@ -40,7 +40,7 @@ Create HTML page with form. On form submit send form data to `https://mate-acade
- Age should be at least `1` and at max `100` with a default value of `12`
- The email field should have placeholder value: `email@example.com`.
- Text fields should have `autocomplete="off"`.
- `Submit` button should have a `type="submit"`
- `Submit` button should have a `type="submit"`
- Vertical distance between inputs should be `10px`
- Vertical distance between groups should be `20px`
- Any other styles should be browser default
Expand Down
169 changes: 168 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,174 @@
<link rel="stylesheet" href="./style.css">
</head>
<body>
<h1>HTML Form</h1>

<form
action="https://mate-academy-form-lesson.herokuapp.com/create-application"
metod="post"
>
<fieldset class="rows">
<legend>Personal information</legend>

<label class="form-field distance">
Surname:
<input
type="text"
name="surname"
autocomplete="off"
>
</label>

<label class="form-field distance">
Name:
<input
type="text"
name="name"
autocomplete="off"
>
</label>

<label class="form-field distance">
How old are You?
<input
type="number"
name="number"
min="1"
max="100"
value="12"
>
</label>

<label class="form-field distance">
Full data of birth:
<input
type="date"
name="birthday"
>
</label>

<label class="form-field">
I accept the term of the agreement:
<input
type="checkbox"
name="agreement"
required
>
</label>

</fieldset>

<fieldset class="rows">
<legend>Registration</legend>

<label class="form-field distance">
E-mail:
<input
type="email"
name="email"
placeholder="email@example.com"
>
</label>

<label class="form-field">
Password:
<input
type="password"
name="password"
minlength="5"
required
>
</label>

</fieldset>

<fieldset class="rows">
<legend>An interesting fact about you!</legend>

<label class="form-field distance">
Copy link

@vlad-demchuk vlad-demchuk Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need this label

Do you love cats?
<input
type="radio"
id="Yes"
name="loveCat"
>
<label for="Yes">Yes</label>
<input
type="radio"
id="No"
name="loveCat"
>
Copy link

@vlad-demchuk vlad-demchuk Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can move these inputs to labels

<label for="No">No</label>
</label>

<label class="form-field distance">
What is your favorite color?
<input
type="color"
name="color"
>
</label>

<label class="form-field distance">
What time do you go to bed?
<input
type="time"
name="go to bed"
step="1"
>
</label>

<div class="form-field distance">
<label for="cars">
What are your favorite brand of cars?
</label>
<select id="cars"
name="cars"
size="4"
multiple>
<option value="BMW">BMW</option>
<option value="Audi">Audi</option>
<option value="Lada">Lada</option>
</select>
</div>

<label class="form-field">
How do you rate our work?
<input
type="range"
name="rate"
>
</label>
</fieldset>

<fieldset class="rows">
<legend>Additional info:</legend>

<label class="form-field distance">
Comments:
<textarea></textarea>
Copy link

@vlad-demchuk vlad-demchuk Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every field should have name attribute

</label>

<div class="form-field">
<label for="recommend">
Would you recommend us?
</label>
<select
name="recommend"
id="recommend"
>
<option value="yes">Yes</option>
<option value="no">No</option>
</select>
</div>

</fieldset>

<button type="submit">
Submit
</button>

</form>

<script type="text/javascript" src="./main.js"></script>
</body>
</html>
12 changes: 11 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,11 @@
/* styles go here */
.form-field {
display: block;
}

.distance {
margin-bottom: 10px;
}

.rows {
margin-bottom: 20px;
}