Skip to content

Conversation

@DariaChk
Copy link

  • DEMO LINK
  • [TEST REPORT LINK] (https://DariaChk.github.io/layout_moyo-header/report/html_report/)
  • Header height is set in 1 place (for the links)
  • Content is vertically centered (for any header height)
  • CSS is used to show all letters in Uppercase (don't type them in HTML)
  • Logo is an image wrapped with a link
  • CSS Variable is used for a blue color
  • Pseudo-element is used for a blue line below the active link
  • Code follows all the Code Style Rules ❗️
  • The Google Fonts Configuration follows requirements.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Good work on this task! The header is implemented correctly using Flexbox, and you've successfully used CSS variables and pseudo-elements. However, a couple of changes are needed to meet all the project requirements before this can be approved.

First, the alt attribute for the logo image in src/index.html needs to be more descriptive. Instead of alt="logo", it should describe the image's content, like alt="Moyo company logo", to improve accessibility.

Second, your HTML formatting doesn't fully align with the Code Style guide [CHECKLIST ITEM #7]. Please ensure that elements with more than two attributes have each attribute on a new line, and add empty lines between multi-line <li> elements for better readability. Once these items are addressed, your work will be ready!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

src/index.html Outdated
>
<img
src="images/logo.png"
alt="logo"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alt attribute should be more descriptive. According to the code style rules, it should describe the image content. For example, Moyo company logo would be a better description than just logo.

src/style.css Outdated
border-radius: 8px;
position: absolute;
background-color: var(--blue);
width: 100%;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When an absolutely positioned element has both left: 0 and right: 0, it will automatically stretch to the full width of its relative parent. This makes the width: 100% property redundant here.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this revision! You've successfully addressed all the feedback from the previous review, and your implementation now meets all the project requirements. I am happy to approve your solution.

I have one small suggestion for future reference regarding the font-family property in src/style.css. It's a best practice to place the generic font family (e.g., sans-serif) last in the list as the ultimate fallback. The recommended order would be Roboto, Arial, sans-serif.

This is just a minor point for improvement and doesn't block this approval. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

body {
margin: 0;
box-sizing: border-box;
font-family: Roboto, sans-serif, Arial;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good use of fallback fonts. According to best practices, the generic font family name (in this case, sans-serif) should be the last one in the list. The browser goes through the list from left to right, so the generic family is the ultimate fallback if no other specified fonts are available. The recommended order is Roboto, Arial, sans-serif.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants