add task solution #7276
add task solution #7276
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This is a very strong submission, and your HTML structure is excellent! However, a couple of changes are needed in your CSS file to meet all the project's technical requirements. Specifically, the use of the universal selector (*) and styling elements by tag name (.logo img) are not allowed according to the task rules. Please remove the universal selector and instead add a specific class to the <img> tag to style it. Once these adjustments are made, your work will be ready for approval. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/style.css
Outdated
| padding: 0; | ||
| } | ||
|
|
||
| * { |
There was a problem hiding this comment.
The use of the universal selector * is not allowed according to the task requirements. While it's a common practice for setting box-sizing, the instructions specifically forbid it to avoid potential performance impacts. Please apply this style to specific elements or use a different approach.
src/style.css
Outdated
| padding: 0 50px; | ||
| } | ||
|
|
||
| .logo img { |
There was a problem hiding this comment.
The task requirements state that tag names should not be used for styling (except for html and body). This selector .logo img violates that rule. To fix this, you should add a specific class to the <img> tag in your HTML file and use that class for styling here.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! I am happy to approve it. You've successfully addressed all the feedback from the previous review, and your code now fully meets all project requirements. The HTML is well-structured and semantic, and the CSS implementation is clean and efficient. This is a fantastic result, keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
[x] - Header height is set in 1 place (for the links)
[x] - Content is vertically centered (for any header height)
[x] - CSS is used to show all letters in Uppercase (don't type them in HTML)
[x] - Logo is an image wrapped with a link
[x] - CSS Variable is used for a blue color
[x] - Pseudo-element is used for a blue line below the active link
[x] - Code follows all the Code Style Rules ❗️
[x] - The Google Fonts Configuration follows requirements.
DEMO LINK
TEST REPORT LINK