Skip to content

Conversation

@SenyaKir
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • [x]Header height is set in 1 place (for the links)

  • [x]Content is vertically centered (for any header height)

  • [x]CSS is used to show all letters in Uppercase (don't type them in HTML)

  • [x]Logo is an image wrapped with a link

  • [x]CSS Variable is used for a blue color

  • [x]Pseudo-element is used for a blue line below the active link

  • [x]Code follows all the Code Style Rules ❗️

  • [x]The Google Fonts Configuration follows requirements.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this project! I am approving your solution as it meets all the core requirements. Your HTML is well-structured, and the CSS is clean and effectively uses flexbox and variables as specified.

As a small suggestion for future improvement, consider making the alt attribute for the logo in src/index.html more descriptive. For instance, changing alt="Logo" to alt="Moyo company logo" enhances accessibility for screen reader users. This is a minor point but a great habit to get into. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

<a href="#">
<img
src="images/logo.png"
alt="Logo"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alt attribute should be more descriptive. Instead of just "Logo," describe what the logo represents, for example, "Moyo company logo." This is important for accessibility and aligns with the best practices mentioned in the checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants