Skip to content

Conversation

@SlidingMoon
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job on this task! Your HTML is well-structured with semantic tags, and you've demonstrated a solid understanding of flexbox for the layout.

However, changes are needed because a key technical requirement was not met. The project rules explicitly state not to use the universal selector (*) in your CSS. In src/style.css, you've used * to apply box-sizing: border-box. Please remove this and apply the style only to the elements that need it to comply with the project constraints.

As a minor suggestion for cleaner code, you can also move the font styles from the class on the <body> tag in your HTML directly to the body selector in your CSS.

Once you've addressed the universal selector issue, your solution will be ready for approval. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

src/index.html Outdated
</head>
<body>
<h1>Moyo header</h1>
<body class="roboto-500">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the task allows styling the body tag directly, it's better to apply the font styles to the body selector in your CSS file instead of using a class here. This would make your HTML cleaner by removing an unnecessary class.

src/style.css Outdated
font-variation-settings: 'wdth' 100;
}

* {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requirements explicitly state not to use the universal selector *. While using it for box-sizing is common practice, you need to adhere to the project's specific rules. Please apply this style only to the elements that need it or find an alternative approach that doesn't use *.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this iteration! I am approving your solution. You've successfully addressed the feedback from the previous review by removing the universal selector, and your code is now fully compliant with all project requirements. The HTML is well-structured and semantic, and the CSS is clean and correctly implements the flexbox layout. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants