Skip to content

add search-bar#5413

Open
Tendeeer wants to merge 1 commit into
mate-academy:masterfrom
Tendeeer:develop
Open

add search-bar#5413
Tendeeer wants to merge 1 commit into
mate-academy:masterfrom
Tendeeer:develop

Conversation

@Tendeeer
Copy link
Copy Markdown

  • DEMO LINK
  • TEST REPORT LINK
  • Icon implemented using background-image CSS property
  • Inputs are written inside of 'form' tag with correctly passed attributes
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully meets all functional requirements. Both search bars are properly structured with correct data-qa attributes, full width styling, the 20px gap between them is correctly implemented, and all three states (default/hover/focus) are working as expected. The @font-face implementation and font-weight settings are also correct. The one note about margin handling is a code consistency suggestion rather than a functional issue. While the big search bar has both margin-top and margin-bottom: 20px, the visual output is correct and tests would pass. This is more of a CSS best practice recommendation than a blocker. Your solution is approved and ready to move forward.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/index.html
Comment on lines +40 to +43
name="search"
class="search__input"
placeholder="Try “Los Angeles“"
/>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big search bar has both margin-top: 20px and margin-bottom: 20px. The task requirement states the distance between two search bars must be 20px, which is achieved by the small search bar's margin-top. Remove margin-bottom to follow the checklist rule about consistent margins (only top OR bottom, not both).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants