Develop#5432
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation has two critical issues that will cause automated tests to fail. First, the data-qa="keypress" attribute is incorrectly placed on the small search form's input (around line 43 in src/index.html), but requirements specify it must only be on the big search form's input. Second, the small search form's input incorrectly uses the class search-form__input_big instead of search-form__input_small, which violates BEM naming conventions and will fail tests that check for exact class names. Please fix both the attribute placement and the class name to match the requirements. The visual regression test failures appear to be CI environment rendering differences rather than code issues, so those should resolve once the functional issues are addressed.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| font-weight: 700; | ||
| } | ||
|
|
||
| body { |
There was a problem hiding this comment.
Both search forms are direct children of without semantic wrapping. Consider adding a
or| cursor: text; | ||
| } | ||
|
|
||
| .search-form__label::before { | ||
| content: ""; |
There was a problem hiding this comment.
The data-qa="keypress" attribute should only be on the big search form's input according to the requirements. Remove this from the small search form's input.
| <input | ||
| class="search-form__input search-form__input_big" |
There was a problem hiding this comment.
The small search form input has class 'search-form__input_big' which is incorrect. It should be 'search-form__input_small' to follow proper BEM naming conventions (the element belongs to the small form).
| <input | ||
| class="search-form__input search-form__input_big" | ||
| type="text" | ||
| placeholder="Try "Los Angeles"" |
There was a problem hiding this comment.
The small search form input has class 'search-form__input_big' but it should be 'search-form__input_small' - BEM modifier mismatch. The input belongs to the small form, so it should use the small variant class.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation requires two fixes: (1) Remove the 'data-qa="hover"' attribute from the small search form's input as it is not required; (2) Add a 20px vertical gap between the search forms using margin. Additionally, consider improving performance by avoiding universal resets in CSS.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| width: 19px; | ||
| height: 19px; |
There was a problem hiding this comment.
This input has data-qa="hover" attribute, but the requirements only specify data-qa="keypress" for the big search form's input. The small search form's input should not have a data-qa attribute besides what's on its parent form element.
| justify-content: center; | ||
| margin: 20px auto 0; | ||
| } |
There was a problem hiding this comment.
The * selector impacts performance and violates checklist item #5. Set box-sizing and padding only for elements that need them.
| <input class="search-form__input search-form__input_small" type="text" | ||
| placeholder="Try "Los Angeles"" /> |
There was a problem hiding this comment.
Remove data-qa="hover" from the small search form's input. Only data-qa="keypress" on the big form was specified in requirements.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
2 participants
No description provided.