Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Implement the [Stars Block](https://www.figma.com/file/ojkArVazq7vsX0nbpn9CxZ/Moyo-%2F-Catalog-(ENG)?node-id=11325%3A2960) used in a card and catalog.

Hold `Alt` key (`Option` on MacOS) to measure distances in Figma.
Hold `Alt` key (`Option` on MacOS) to measure distances in Figma.

> Here are the [Layout Tasks Instructions](https://mate-academy.github.io/layout_task-guideline)

Expand All @@ -22,8 +22,8 @@ Hold `Alt` key (`Option` on MacOS) to measure distances in Figma.

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_stars/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_stars/report/html_report/)
- [DEMO LINK](https://Jaseniin.github.io/layout_stars/)
- [TEST REPORT LINK](https://Jaseniin.github.io/layout_stars/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
48 changes: 47 additions & 1 deletion src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,52 @@
/>
</head>
<body>
<h1>Stars</h1>
<div class="stars stars--0">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--2">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--3">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--5">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
</body>
</html>
40 changes: 39 additions & 1 deletion src/style.css
Original file line number Diff line number Diff line change
@@ -1 +1,39 @@
/* add styles here */
body {
margin: 0;
}

.stars {
display: flex;
}

.stars__star {
width: 16px;
height: 16px;
margin-right: 4px;
background-image: url(images/star.svg);
background-size: cover;
}

.stars--0 .stars__star:nth-child(-n + 0) {
background-image: url(images/star-active.svg);
}

.stars--1 .stars__star:nth-child(-n + 1) {
background-image: url(images/star-active.svg);
}

.stars--2 .stars__star:nth-child(-n + 2) {
background-image: url(images/star-active.svg);
}

.stars--3 .stars__star:nth-child(-n + 3) {
background-image: url(images/star-active.svg);
}

.stars--4 .stars__star:nth-child(-n + 4) {
background-image: url(images/star-active.svg);
}

.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url(images/star-active.svg);
}
Comment on lines +5 to +40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Each BEM block has its own separate file'.

As mentioned in the previous review, all styles for the .stars block should be moved into a dedicated file (e.g., src/stars.css). The main style.css should only contain general styles like the body reset, or be removed if all styles are component-based.

Loading