Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job implementing the core logic for the star ratings! The use of BEM modifiers with the :nth-child pseudo-class is well-executed.
Before this can be approved, a few key styling requirements from the task need to be addressed. First, the browser's default margins need to be reset, which can be done by adding margin: 0; to the body selector. Second, the spacing between the stars from the Figma design is missing; you can add this using margin-right on the star elements, making sure to remove it from the last star in each group. Lastly, please remove the unused .stars_star_active class, as it's not needed and doesn't follow the project's BEM conventions [CHECKLIST ITEM #3].
After you've made these adjustments, your project will fully match the design.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| <body> | ||
| <div class="stars stars--0"> | ||
|
|
||
| <a class ="stars__star"> </a> |
There was a problem hiding this comment.
The formatting of attributes is inconsistent throughout the file. For example, there are extra spaces around the = in class attributes (e.g., class ="..."). The standard convention is to have no spaces, like class="...". Please correct this for all similar occurrences in the file.
| .stars__star{ | ||
| width: 20px; | ||
| height: 20px; | ||
| background-image:url(images/star.svg); | ||
| background-size: | ||
| contain; | ||
| background-repeat: no-repeat; | ||
| background-position: center; | ||
| } |
There was a problem hiding this comment.
The task requires setting the distance between stars based on the Figma design. Currently, the stars will have no space between them. Consider adding a margin-right to the star elements and using a pseudo-class like :last-child to remove it from the final star in each group.
| background-size: | ||
| contain; |
There was a problem hiding this comment.
It's standard practice to keep a CSS property and its value on the same line for better readability, like background-size: contain;.
| background-position: center; | ||
| } | ||
|
|
||
| .stars{ |
There was a problem hiding this comment.
The task requires resetting the browser's default margins. This is typically done with a rule for the body element (e.g., body { margin: 0; }) at the start of your stylesheet.
| .stars_star_active{ | ||
| background-image: url(images/star-active.svg); | ||
| } |
There was a problem hiding this comment.
This class .stars_star_active is not used in the HTML and should be removed. The active star state is already correctly handled by the .stars--N modifier classes and the :nth-child selector. Additionally, the class name does not follow BEM naming conventions.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
i suppose this task hasn't finished yet
- please finish this task
- push all your actual code
- deploy your app
- add DEMO LINK to PR's description
- ask for mentor's review again
3 participants
No description provided.