Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This requires a change because the project's file structure does not meet a core requirement. Your visual implementation is excellent, and the BEM classes in the HTML are used correctly. However, all styles are currently in a single style.css file. The task requires that each BEM block has its own separate file [CHECKLIST ITEM #2]. Please move all styles related to the stars block into their own file, such as stars.css.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/style.css
Outdated
| .stars { | ||
| display: flex; | ||
| padding: 0; | ||
| } |
There was a problem hiding this comment.
This violates checklist item #2: 'Each BEM block has its own separate file'. The styles for the stars block should be in their own file (e.g., stars.css) to separate block-specific styles from global styles like those for the body tag.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this update! You've done a great job addressing the previous feedback by moving all the styles for the stars block into their own dedicated stars.css file. This separation of concerns is a key principle of BEM and you've implemented it perfectly. The project now meets all the requirements, and the code is clean and well-structured. I am happy to approve your solution. Keep up the fantastic work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.