Skip to content

add task solution - #6956

Open
DmutroHavriliuk wants to merge 1 commit into
mate-academy:masterfrom
DmutroHavriliuk:develop
Open

add task solution#6956
DmutroHavriliuk wants to merge 1 commit into
mate-academy:masterfrom
DmutroHavriliuk:develop

Conversation

@DmutroHavriliuk

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The stars block styles are currently in style.css but must be moved to a dedicated stars.css file as required by the checklist item [CHECKLIST ITEM - Each BEM block has its own separate file]. This is an explicit structural requirement for the assignment.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/style.css
Comment on lines 1 to +28
/* add styles here */
body {
margin: 0;
}

.stars {
display: flex;
}

.stars__star {
width: 16px;
height: 16px;
margin-right: 4px;

background: url('./images/star.svg') center no-repeat;
}

.stars__star:last-child {
margin-right: 0;
}

.stars--1 .stars__star:nth-child(-n + 1),
.stars--2 .stars__star:nth-child(-n + 2),
.stars--3 .stars__star:nth-child(-n + 3),
.stars--4 .stars__star:nth-child(-n + 4),
.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url('./images/star-active.svg');
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item violated: 'Each BEM block has its own separate file'. The stars styles are in style.css but should be in a dedicated stars.css file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants