add task solution - #6964
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation has correct star rating functionality with proper BEM naming and working CSS selectors, but there's a critical checklist violation: the requirement 'Each BEM block has its own separate file' is not satisfied. All CSS is in a single style.css file instead of separate files for each BEM block. You need to split the CSS into separate files - at minimum stars.css for the stars block and stars__star.css for the stars__star element. Additionally, the image paths use absolute paths (/src/images/star.svg) which may cause deployment issues - consider using relative paths like ./images/star.svg. The core functionality is solid, but the file structure must match the checklist requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| /* #region page */ | ||
|
|
||
| body { | ||
| margin: 0; | ||
| } | ||
|
|
||
| /* #endregion */ | ||
|
|
||
| .stars { | ||
| display: flex; | ||
| } | ||
|
|
||
| .stars__star { | ||
| width: 16px; | ||
| height: 16px; | ||
| margin-right: 4px; | ||
|
|
||
| background-image: url(/src/images/star.svg); | ||
| background-position: center; | ||
| background-repeat: no-repeat; | ||
| } | ||
|
|
||
| .stars__star:last-child { | ||
| margin-right: 0; | ||
| } | ||
|
|
||
| .stars--1 > *:nth-child(1), | ||
| .stars--2 > *:nth-child(-n + 2), | ||
| .stars--3 > *:nth-child(-n + 3), | ||
| .stars--4 > *:nth-child(-n + 4), | ||
| .stars--5 > *:nth-child(-n + 5) { | ||
| background-image: url(/src/images/star-active.svg); | ||
| } |
There was a problem hiding this comment.
Checklist violation: 'Each BEM block has its own separate file' - All CSS is in one file. According to the requirements, each BEM block should have its own separate CSS file.
|
Done |
2 participants
No description provided.