Skip to content

Develop - #6972

Open
Marfo0 wants to merge 3 commits into
mate-academy:masterfrom
Marfo0:develop
Open

Develop#6972
Marfo0 wants to merge 3 commits into
mate-academy:masterfrom
Marfo0:develop

Conversation

@Marfo0

@Marfo0 Marfo0 commented Aug 3, 2026

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The implementation is functionally correct with all tests passing, but there's a critical checklist violation: all CSS styles are in a single style.css file when the checklist explicitly requires each BEM block to have its own separate file (e.g., stars.css for the stars block). This is a structural requirement that must be addressed. Additionally, the CSS selectors for active stars have repetitive .stars__star:nth-child blocks that could be consolidated using a combined selector pattern to reduce code duplication.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/style.css Outdated
Comment on lines +1 to +26
/* add styles here */
body {
margin: 0;
}

.stars {
display: flex;
}

.stars__star {
width: 16px;
height: 16px;
margin-right: 4px;

background-image: url(images/star.svg);
background-repeat: no-repeat;
background-position: center;
}

.stars--1 .stars__star:nth-child(-n + 1),
.stars--2 .stars__star:nth-child(-n + 2),
.stars--3 .stars__star:nth-child(-n + 3),
.stars--4 .stars__star:nth-child(-n + 4),
.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url(images/star-active.svg);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist violation: 'Each BEM block has its own separate file'. The CSS has all styles in a single style.css file. According to BEM methodology and the checklist requirements, each BEM block should have its own separate file (e.g., stars.css for the stars block).

Comment thread src/style.css Outdated
Comment on lines +19 to +25

.stars--1 .stars__star:nth-child(-n + 1),
.stars--2 .stars__star:nth-child(-n + 2),
.stars--3 .stars__star:nth-child(-n + 3),
.stars--4 .stars__star:nth-child(-n + 4),
.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url(images/star-active.svg);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS selectors for active stars could be consolidated using a combined selector pattern. Currently each modifier has its own selector block which creates repetition. Consider using a shared selector to reduce code duplication.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

All functional requirements are met: CSS is properly split into separate files, the 6 stars blocks with modifiers (stars--0 through stars--5) work correctly, flexbox layout is implemented without the gap property, and the combined selector pattern properly activates the correct number of stars using background-image. The implementation correctly follows BEM naming conventions with each block in its own file. One minor note: in src/index.html, the second stylesheet link has inconsistent relative path formatting compared to the first—consider using href="./stars.css" to match the style of href="./style.css". However, this is purely cosmetic and doesn't affect functionality.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/index.html
Comment on lines +14 to +16
<link
rel="stylesheet"
href="stars.css"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href should use consistent relative path with ./ prefix like the previous link: href="./stars.css"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants