Skip to content

add task solution - #6976

Open
Baragar896 wants to merge 2 commits into
mate-academy:masterfrom
Baragar896:develop
Open

add task solution#6976
Baragar896 wants to merge 2 commits into
mate-academy:masterfrom
Baragar896:develop

Conversation

@Baragar896

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation correctly handles the star rating functionality with proper BEM methodology, flexbox layout, and background-image for stars. However, there's a critical checklist violation: the requirement explicitly states 'Each BEM block has its own separate file'. Currently, all your CSS is in a single style.css file, but the .stars block styles need to be moved to a dedicated stars.css file. Your style.css should only contain the body { margin: 0; } reset. This is a structural requirement that blocks task completion as defined by the checklist.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/style.css Outdated
Comment on lines +1 to +27
body {
margin: 0;
}

.stars {
display: flex;
}

.stars__star {
width: 16px;
height: 16px;
background-image: url('images/star.svg');
background-repeat: no-repeat;
background-position: center;
}

.stars__star:not(:last-child) {
margin-right: 4px;
}

.stars--1 .stars__star:nth-child(-n + 1),
.stars--2 .stars__star:nth-child(-n + 2),
.stars--3 .stars__star:nth-child(-n + 3),
.stars--4 .stars__star:nth-child(-n + 4),
.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url('images/star-active.svg');
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist violation: 'Each BEM block has its own separate file' - The stars block styles should be in a separate stars.css file, not in style.css. The CSS file should only contain the body { margin: 0; } reset.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution. The HTML correctly includes six .stars blocks, each with five .stars__star elements and the required modifiers .stars--0 through .stars--5. Your CSS separation follows BEM expectations with stars.css holding the block styles, and the active stars are handled via container modifiers with :nth-child(-n+N) selectors, using background images and flex layout without gap. Please ensure style.css contains only the reset body { margin: 0; } so the separation of concerns is clear and tests won’t flag extra styles in the reset file. As a minor polish, double-check star sizing and spacing align with the Figma measurements and that there are no vertical margins between blocks. Nicely done applying pseudo-selectors and keeping the HTML clean without extra classes.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants