Solution - #6978
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation has 2 critical issues that violate explicit task requirements and must be fixed:
-
Missing body margin reset [CHECKLIST ITEM: HTML Formatting] — The task explicitly requires "Reset browser's default
margin", butbody { margin: 0; }is absent from your CSS. Add this tosrc/style.css. -
CSS not separated into BEM block files [CHECKLIST ITEM: Code Structure] — The checklist explicitly requires "Each BEM block has its own separate file", but all styles are in a single
style.css. Move the.starsblock CSS to a newsrc/stars.cssfile.
The visual regression test failures (23-36% mismatch) are likely caused by the missing margin reset affecting the page layout. Once you add body { margin: 0; }, the visual tests should pass since the reference images were likely generated with this reset in place.
Fix these two issues and re-submit — all functional requirements (6 stars blocks, proper BEM naming, correct selectors, 16px star size) are correctly implemented.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| href="./style.css" | ||
| /> | ||
| </head> | ||
| <body> |
There was a problem hiding this comment.
The task requires 'Reset browser's default margin', but there's no CSS reset. Add margin: 0; to body element to reset default margins.
| @@ -1 +1,24 @@ | |||
| /* add styles here */ | |||
| .stars { | |||
There was a problem hiding this comment.
The task requires resetting browser's default margin on the body. Add margin: 0; to the body selector.
| .stars { | ||
| display: flex; | ||
| } | ||
|
|
||
| .stars__star { | ||
| width: 16px; | ||
| height: 16px; | ||
| background-image: url('./images/star.svg'); | ||
| background-repeat: no-repeat; | ||
| background-position: center; | ||
| background-size: contain; | ||
| } | ||
|
|
||
| .stars__star:not(:last-child) { | ||
| margin-right: 4px; | ||
| } | ||
|
|
||
| .stars--1 .stars__star:nth-child(-n + 1), | ||
| .stars--2 .stars__star:nth-child(-n + 2), | ||
| .stars--3 .stars__star:nth-child(-n + 3), | ||
| .stars--4 .stars__star:nth-child(-n + 4), | ||
| .stars--5 .stars__star:nth-child(-n + 5) { | ||
| background-image: url('./images/star-active.svg'); | ||
| } |
There was a problem hiding this comment.
Checklist item violation: 'Each BEM block has its own separate file'. The stars block CSS should be in a separate file (e.g., stars.css) instead of style.css.
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the [Code Style Rules ❗️]