Skip to content

Solution - #6978

Open
roazerini wants to merge 1 commit into
mate-academy:masterfrom
roazerini:Develop
Open

Solution#6978
roazerini wants to merge 1 commit into
mate-academy:masterfrom
roazerini:Develop

Conversation

@roazerini

@roazerini roazerini commented Aug 8, 2026

Copy link
Copy Markdown
  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the [Code Style Rules ❗️]

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation has 2 critical issues that violate explicit task requirements and must be fixed:

  1. Missing body margin reset [CHECKLIST ITEM: HTML Formatting] — The task explicitly requires "Reset browser's default margin", but body { margin: 0; } is absent from your CSS. Add this to src/style.css.

  2. CSS not separated into BEM block files [CHECKLIST ITEM: Code Structure] — The checklist explicitly requires "Each BEM block has its own separate file", but all styles are in a single style.css. Move the .stars block CSS to a new src/stars.css file.

The visual regression test failures (23-36% mismatch) are likely caused by the missing margin reset affecting the page layout. Once you add body { margin: 0; }, the visual tests should pass since the reference images were likely generated with this reset in place.

Fix these two issues and re-submit — all functional requirements (6 stars blocks, proper BEM naming, correct selectors, 16px star size) are correctly implemented.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/index.html
href="./style.css"
/>
</head>
<body>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires 'Reset browser's default margin', but there's no CSS reset. Add margin: 0; to body element to reset default margins.

Comment thread src/style.css
@@ -1 +1,24 @@
/* add styles here */
.stars {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires resetting browser's default margin on the body. Add margin: 0; to the body selector.

Comment thread src/style.css
Comment on lines +1 to +24
.stars {
display: flex;
}

.stars__star {
width: 16px;
height: 16px;
background-image: url('./images/star.svg');
background-repeat: no-repeat;
background-position: center;
background-size: contain;
}

.stars__star:not(:last-child) {
margin-right: 4px;
}

.stars--1 .stars__star:nth-child(-n + 1),
.stars--2 .stars__star:nth-child(-n + 2),
.stars--3 .stars__star:nth-child(-n + 3),
.stars--4 .stars__star:nth-child(-n + 4),
.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url('./images/star-active.svg');
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item violation: 'Each BEM block has its own separate file'. The stars block CSS should be in a separate file (e.g., stars.css) instead of style.css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants