Skip to content

added task solution - #6981

Open
MrMadis wants to merge 2 commits into
mate-academy:masterfrom
MrMadis:develop
Open

added task solution#6981
MrMadis wants to merge 2 commits into
mate-academy:masterfrom
MrMadis:develop

Conversation

@MrMadis

@MrMadis MrMadis commented Aug 9, 2026

Copy link
Copy Markdown
  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because there is a critical checklist violation: the stars BEM block styles are not in their own file [CHECKLIST ITEM #2]. In src/style.css, all styles for the stars block are grouped together instead of being moved to a dedicated src/stars.css. The checklist explicitly requires each BEM block to live in its own file, so this must be addressed before approval.

What to fix:

  • Move all rules for the stars block (e.g., .stars, .stars__star, .stars--0.stars--5, and any related pseudo-selectors) from src/style.css into a new file src/stars.css.
  • Update your HTML to include stars.css (e.g., add a <link> tag) and ensure no regressions.

Everything else looks solid: the HTML uses correct BEM naming and structure, and the CSS meets functional requirements (sizes, layout, background images, and modifier behavior). Once the block is split into its own file, this should be ready to approve. Keep up the good work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/style.css
@@ -1 +1,41 @@
/* add styles here */

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist Item #2 violation: Each BEM block must have its own separate file. The stars block styles should be moved to a dedicated stars.css file instead of being in style.css.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation is approved. All requirements have been successfully met: the stars block styles are properly separated into src/stars.css [CHECKLIST ITEM #2], the HTML uses correct BEM naming with exactly 6 blocks and 5 stars each, modifiers stars--0 through stars--5 correctly activate N stars using :nth-child(-n + N) selectors, display: flex is used without the gap property, and stars are styled with background-image for both inactive and active states. The code follows all style guidelines with proper indentation and no extra classes. Great work completing this task!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants