-
Notifications
You must be signed in to change notification settings - Fork 755
Solution #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saulorodrigocfs
wants to merge
3
commits into
mate-academy:master
Choose a base branch
from
saulorodrigocfs:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Solution #656
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,68 @@ | ||
| class Deck: | ||
| def __init__(self, row, column, is_alive=True): | ||
| pass | ||
| def __init__(self, row: int, column: int, is_alive: bool = True) -> None: | ||
| self.row = row | ||
| self.column = column | ||
| self.is_alive = is_alive | ||
|
|
||
|
|
||
| class Ship: | ||
| def __init__(self, start, end, is_drowned=False): | ||
| # Create decks and save them to a list `self.decks` | ||
| pass | ||
| def __init__( | ||
| self, | ||
| start: tuple, | ||
| end: tuple, | ||
| is_drowned: bool = False | ||
| ) -> None: | ||
| if start[0] == end[0] and start[1] <= end[1]: | ||
| self.decks = [ | ||
| Deck(start[0], i) for i in range(start[1], end[1] + 1) | ||
| ] | ||
| elif start[0] == end[0] and start[1] > end[1]: | ||
| self.decks = [ | ||
| Deck(start[0], i) for i in range(end[1], start[1] + 1) | ||
| ] | ||
| elif start[1] == end[1] and start[0] <= end[0]: | ||
| self.decks = [ | ||
| Deck(i, start[1]) for i in range(start[0], end[0] + 1) | ||
| ] | ||
| elif start[1] == end[1] and start[0] > end[0]: | ||
| self.decks = [ | ||
| Deck(i, start[1]) for i in range(end[0], start[0] + 1) | ||
| ] | ||
| self.is_drowned = is_drowned | ||
|
|
||
| def get_deck(self, row, column): | ||
| # Find the corresponding deck in the list | ||
| pass | ||
| def get_deck(self, row: int, column: int) -> Deck | None: | ||
| for deck in self.decks: | ||
| if deck.column == column and deck.row == row: | ||
| return deck | ||
| return None | ||
|
|
||
| def fire(self, row, column): | ||
| # Change the `is_alive` status of the deck | ||
| # And update the `is_drowned` value if it's needed | ||
| pass | ||
| def fire(self, row: int, column: int) -> None: | ||
| deck_shot = self.get_deck(row, column) | ||
| if deck_shot is None: | ||
| return | ||
| deck_shot.is_alive = False | ||
| count = 0 | ||
| for deck in self.decks: | ||
| if deck.is_alive is False: | ||
| count += 1 | ||
| if len(self.decks) == count: | ||
| self.is_drowned = True | ||
|
|
||
|
|
||
| class Battleship: | ||
| def __init__(self, ships): | ||
| # Create a dict `self.field`. | ||
| # Its keys are tuples - the coordinates of the non-empty cells, | ||
| # A value for each cell is a reference to the ship | ||
| # which is located in it | ||
| pass | ||
| def __init__(self, ships: list) -> None: | ||
| self.field = {} | ||
| for ship_tuple in ships: | ||
| ship_obj = Ship(ship_tuple[0], ship_tuple[1]) | ||
| for deck in ship_obj.decks: | ||
| self.field[(deck.row, deck.column)] = ship_obj | ||
saulorodrigocfs marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| def fire(self, location: tuple): | ||
| # This function should check whether the location | ||
| # is a key in the `self.field` | ||
| # If it is, then it should check if this cell is the last alive | ||
| # in the ship or not. | ||
| pass | ||
| def fire(self, location: tuple) -> str: | ||
| if location not in self.field: | ||
| return "Miss!" | ||
| ship = self.field[location] | ||
| ship.fire(location[0], location[1]) | ||
| if ship.is_drowned: | ||
| return "Sunk!" | ||
| else: | ||
| return "Hit!" | ||
saulorodrigocfs marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.