Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 80 additions & 25 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,34 +1,89 @@
class Deck:
def __init__(self, row, column, is_alive=True):
pass
def __init__(
self,
row: int,
column: int,
is_alive: bool = True
) -> None:
self.row = row
self.column = column
self.is_alive = is_alive


class Ship:
def __init__(self, start, end, is_drowned=False):
# Create decks and save them to a list `self.decks`
pass
def __init__(
self,
start: int,
end: int,
is_drowned: bool = False
) -> None:
self.start_x, self.start_y = start
self.end_x, self.end_y = end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These attributes (start_x, start_y, end_x, end_y) are only used within the __init__ method to create the decks. They are not used anywhere else in the Ship class. This violates checklist item #4: 'Remove unused attributes.' Consider using local variables within __init__ instead of instance attributes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These attributes (start_x, start_y, end_x, end_y) are only used within the __init__ method to create the decks. They are not used by any other methods in the Ship class. This violates checklist item #4: 'Remove unused attributes.' Consider making them local variables within this method.

self.is_drowned = is_drowned
self.decks = []

def get_deck(self, row, column):
# Find the corresponding deck in the list
pass
if self.start_x == self.end_x:
for y_coord in range(
min(self.start_y, self.end_y),
max(self.start_y, self.end_y) + 1):
self.decks.append(Deck(self.start_x, y_coord))

def fire(self, row, column):
# Change the `is_alive` status of the deck
# And update the `is_drowned` value if it's needed
pass
elif self.start_y < self.end_y:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition for identifying a horizontal ship is incorrect. A ship is horizontal if its start and end y-coordinates are the same. This condition should check for equality (self.start_y == self.end_y) to correctly handle horizontal ships.

for x_coord in range(
min(self.start_x, self.end_x),
max(self.start_x, self.end_x) + 1):
self.decks.append(Deck(x_coord, self.start_y))
else:
return

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block violates checklist item #2. An __init__ method should not fail silently by returning. This creates an object in an invalid state (a ship with no decks). Instead, you should raise an exception (e.g., ValueError) for invalid ship coordinates like diagonal ones.


def get_deck(
self,
row: int,
column: int
) -> None:
for deck in self.decks:
if deck.row == row and deck.column == column:
return deck
return None

def fire(
self,
row: int,
column: int
) -> None:
deck = self.get_deck(row, column)
if deck:
deck.is_alive = False
for _deck in self.decks:
if _deck.is_alive is True:
return
self.is_drowned = True


class Battleship:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Battleship class is missing the print_field and _validate_field methods, which are required by the 'Extra tasks' section in the task description. Please implement these methods to add the required printing and validation functionality.

def __init__(self, ships):
# Create a dict `self.field`.
# Its keys are tuples - the coordinates of the non-empty cells,
# A value for each cell is a reference to the ship
# which is located in it
pass

def fire(self, location: tuple):
# This function should check whether the location
# is a key in the `self.field`
# If it is, then it should check if this cell is the last alive
# in the ship or not.
pass
def __init__(
self,
ships: list
) -> None:
self.ships = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The self.ships attribute is populated in the __init__ method but is never used afterward. This violates checklist item #4: 'Remove unused attributes.' A local variable within __init__ would be more appropriate for building the ships before populating self.field.

self.field = {}
for start, end in ships:
new_ship = Ship(start, end)
self.ships.append(new_ship)

for ship in self.ships:
for deck in ship.decks:
coord = (deck.row, deck.column)
self.field[coord] = ship
Comment on lines +64 to +77

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _validate_field method is correctly implemented, but it's not being called from within this __init__ method. According to the requirements, you need to call self._validate_field() at the end of this method, after the field has been fully initialized.


def fire(
self,
location: tuple
) -> str:
if location not in self.field:
return "Miss!"
target_ship = self.field[location]
target_ship.fire(*location)
if target_ship.is_drowned:
return "Sunk!"
return "Hit!"