Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This is a solid attempt, and the overall structure is good. However, a couple of changes are needed to meet all the requirements. The calculate_washing_price method must return its value rounded to one decimal place, as specified in the task description. Currently, it returns the unrounded price. Also, the type hint for distance_from_city_center in the CarWashStation constructor should be float instead of int. Please make these adjustments, and your solution will be ready for approval.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
app/main.py
Outdated
| # write your code here | ||
| pass | ||
| def __init__(self, | ||
| distance_from_city_center: int, |
There was a problem hiding this comment.
The task description specifies that distance_from_city_center should be a float (from 1.0 to 10.0), but the type hint here is int.
| * (self.clean_power - car.clean_mark) | ||
| * self.average_rating / self.distance_from_city_center | ||
| ) | ||
| return price |
There was a problem hiding this comment.
The requirements state that this method should return the price rounded to 1 decimal place. Currently, the raw unrounded value is being returned.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on this iteration! I am approving your solution as you've successfully addressed all the previous feedback. The type hint for distance_from_city_center is now correct, and the calculate_washing_price method properly rounds the result as required. Your code is clean, well-structured, and now fully meets all the requirements of the task. Keep up the excellent work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.