Skip to content

Develop#1363

Open
TomekSzatal wants to merge 3 commits intomate-academy:masterfrom
TomekSzatal:develop
Open

Develop#1363
TomekSzatal wants to merge 3 commits intomate-academy:masterfrom
TomekSzatal:develop

Conversation

@TomekSzatal
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great work on this task! Your solution correctly implements all the core requirements for the home page. The view logic, template structure, and URL routing are all set up properly. I am approving your submission.

For future projects, please pay closer attention to the code style guidelines mentioned in the checklist. Specifically:

  • In taxi/urls.py and taxi/views.py, remember to separate third-party imports from local application imports with a blank line. [CHECKLIST ITEM #2]
  • In taxi/urls.py, please use an absolute import like from taxi import views instead of the relative import from . import views. [CHECKLIST ITEM #3]
  • Also, remember to remove auto-generated comments and ensure all files end with a single blank line. [CHECKLIST ITEM #1]

These are minor points that will improve your code's readability. Keep up the excellent work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

@@ -1,3 +1,16 @@
from django.shortcuts import render
from taxi.models import Driver, Manufacturer, Car

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Add a blank line between different groups of imports...'. According to the code style guidelines, you should separate third-party imports (like django) from local application imports (like taxi) with a blank line.

@@ -0,0 +1,9 @@
from django.urls import path

from . import views

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Add a blank line between different groups of imports...'. A blank line should be added before this line to separate third-party imports (like Django) from local application imports.

@@ -0,0 +1,9 @@
from django.urls import path

from . import views

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #3: 'Use absolute imports instead of relative imports'. Please change this relative import to an absolute import, such as from taxi import views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants