add tests

[RimmaBuzuluk]

No description provided.

[mateacademy-ai-mentor]

Review Summary

Great job setting up the tests for the ifElse function! You've correctly used mock functions to verify the main conditional logic. However, the tests are missing a couple of key requirements from the task description, so some changes are needed before this can be approved.

Specifically, your tests need to verify two more things:

1. No return value: The ifElse function should not return a value. Please add an assertion to confirm its result is undefined.
2. No arguments for callbacks: The tests should ensure that the condition, first, and second functions are called with no arguments. You can check this by using toHaveBeenCalledWith() on your mocks.

Once you add these assertions, your tests will fully cover all the requirements. Let me know if you have any questions!

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

Your tests cover the callback execution logic well. However, the task description mentions that 'No result is expected from isElse function'. Could you add a separate test case to confirm that ifElse returns undefined?

[mateacademy-ai-mentor]

This correctly asserts that the condition function was called. To be more thorough and meet all requirements, you should also verify that it was called with no arguments. You can achieve this with expect(condition).toHaveBeenCalledWith(). The same applies to the first and second callbacks when they are executed.

[mateacademy-ai-mentor]

Review Summary

Great job adding the test to verify that ifElse returns undefined! We're very close to finishing this task.

However, one key requirement is not yet met. The tests need to verify that the condition, first, and second callback functions are called with no arguments. Your current tests use .toHaveBeenCalled(), which only checks if the function was called, but not what it was called with.

Please update your assertions to use .toHaveBeenCalledWith() to ensure no arguments are passed to the callbacks. This will fully satisfy the task requirements.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

These assertions correctly check that the functions were called. However, the task requires ensuring they were called with no arguments. You can verify this by changing .toHaveBeenCalled() to .toHaveBeenCalledWith().

[mateacademy-ai-mentor]

Similar to the test case above, this should also verify that condition was called with no arguments. Please use .toHaveBeenCalledWith().

[mateacademy-ai-mentor]

Please also verify here that the second function was called with no arguments by using .toHaveBeenCalledWith().