Skip to content

Add task solution #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Igrik74 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add task solution #237

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cfaeaf
Add task solution
Igrik74 Jan 27, 2026
e89cd12
Solution
Igrik74 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 39 additions & 3 deletions src/ifElse.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,47 @@
'use strict';

const { ifElse } = require('./ifElse');

describe('ifElse', () => {
// const { ifElse } = require('./ifElse');
it('calls the condition callback once', () => {
const condition = jest.fn(() => true);
const first = jest.fn();
const second = jest.fn();

ifElse(condition, first, second);

expect(condition).toHaveBeenCalledTimes(1);
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion correctly verifies that condition is called. The requirements also state that it should be run with no arguments. You can strengthen this test by also asserting it was called with no arguments, for example, by using .toHaveBeenCalledWith().

});

it('runs the first callback when condition returns true', () => {
const condition = jest.fn(() => true);
const first = jest.fn();
const second = jest.fn();

ifElse(condition, first, second);

it('should ', () => {
expect(first).toHaveBeenCalledTimes(1);
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job checking that the first callback is executed. To make the test fully align with the implied behavior from the task description's example, you could also add an assertion that first is called with no arguments.

expect(second).not.toHaveBeenCalled();
});

it('runs the second callback when condition returns false', () => {
const condition = jest.fn(() => false);
const first = jest.fn();
const second = jest.fn();

ifElse(condition, first, second);

expect(second).toHaveBeenCalledTimes(1);
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This correctly tests that the second callback is run. The requirements explicitly state that second should be run 'with no arguments'. It would be best to add an assertion to verify this, for instance, with .toHaveBeenCalledWith().

expect(first).not.toHaveBeenCalled();
});

// write tests here
it('returns undefined', () => {
const condition = jest.fn(() => true);
const first = jest.fn();
const second = jest.fn();

const result = ifElse(condition, first, second);

expect(result).toBeUndefined();
});
});