Skip to content

solution #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Radymyr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

solution #553

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d910218
solution
Radymyr Jan 28, 2026
a67a41b
fix: fixed arguments naming
Radymyr Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/isIsogram.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,18 @@ describe('isIsogram', () => {
it(`should be declared`, () => {
expect(isIsogram).toBeInstanceOf(Function);
});

const isIsogramMap = {
playgrounds: true,
look: false,
Adam: false,
'': true,
Oops: false,
};

for (const key in isIsogramMap) {
it(`should ${isIsogramMap[key]} if ${key} passed`, () => {
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated test descriptions are not very clear, especially for the empty string, which results in should true if passed. According to the requirements, each test case should have a clear and unique description. Consider rewording this to be more explicit, for example: it(should return ${isIsogramMap[key]} for the word "${key}", ...).

expect(isIsogram(key)).toBe(isIsogramMap[key]);
});
}
});