Skip to content

solution #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Radymyr wants to merge 4 commits into
base: master
Choose a base branch
from
Open

solution #324

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea21164
solution
Radymyr Jan 31, 2026
a0b7134
solution
Radymyr Jan 31, 2026
1387b56
solution
Radymyr Jan 31, 2026
239e314
fixed
Radymyr Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions src/restoreNames.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,31 @@
'use strict';
"use strict";

describe('restoreNames', () => {
// const { restoreNames } = require('./restoreNames');
describe("restoreNames", () => {
const { restoreNames } = require("./restoreNames");

it('should ', () => {
const users = [
{
firstName: undefined,
lastName: "Holy",
fullName: "Jack Holy",
},
{
lastName: "Adams",
fullName: "Mike Adams",
},
];
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This users array is defined in a shared scope and gets mutated by your first test. The second test then operates on this already-modified data, which means it isn't testing the original scenario. Tests must be independent. To fix this, you can either create a fresh copy of the users array inside each it block or use Jest's beforeEach hook to reset the data before each test.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This users array is defined once and then mutated by your tests. This means the tests are not isolated from each other, and the outcome of one can affect the next. To ensure each test is reliable and independent, you should provide a fresh copy of the test data for each test case. A beforeEach block is a great way to handle this.


it("should be a function", () => {
expect(restoreNames).toBeInstanceOf(Function);
});

// write tests here
it("should have firstName", () => {
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test and the one on line 27 have the same name. It's a best practice to give each test a unique and descriptive name that explains the specific scenario it covers.

restoreNames(users);
expect(users[0].firstName).toBe("Jack");
});

it("should have firstName", () => {
restoreNames(users);
expect(users[1].firstName).toBe("Mike");
});
});
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the key requirements is that the function should not return a value. As mentioned in the previous review, you need to add a test case to verify that calling restoreNames results in undefined.