Skip to content

done Phone catalog task#924

Open
maximtsyrulnyk wants to merge 4 commits intomate-academy:masterfrom
maximtsyrulnyk:develop
Open

done Phone catalog task#924
maximtsyrulnyk wants to merge 4 commits intomate-academy:masterfrom
maximtsyrulnyk:develop

Conversation

@maximtsyrulnyk
Copy link

done Phone catalog task

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but rpovide the DEMO LINK before requesting the review

@maximtsyrulnyk maximtsyrulnyk requested a review from brespect March 9, 2026 10:07
@maximtsyrulnyk
Copy link
Author

@maximtsyrulnyk
Copy link
Author

DEMO LINK

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, lets check this:

  1. Add some padding here:
Image
  1. If you have the ability to search in Phones, Tablets, Accessories and it also to the Favourites.

  2. All links should redirect to proper resourses:

Image
  1. If I select something in this section it should scroll me smooth to the top:
Image
  1. Search Bar looks broken on Mobile version:
Image

@maximtsyrulnyk
Copy link
Author

edited code according Last Reccommendations DEMO LINK

@maximtsyrulnyk maximtsyrulnyk requested a review from brespect March 10, 2026 09:49
Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, change the browser tab title:
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants