Skip to content

add task solution#927

Open
maksymkolomiiets2-svg wants to merge 4 commits intomate-academy:masterfrom
maksymkolomiiets2-svg:develop
Open

add task solution#927
maksymkolomiiets2-svg wants to merge 4 commits intomate-academy:masterfrom
maksymkolomiiets2-svg:develop

Conversation

@maksymkolomiiets2-svg
Copy link

Copy link

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👏

here are some improvements:

  1. icons is better to use in svg format
Image
  1. it's better to change styles little bit for button "added to card"
Image
  1. on mobile this icons look broken
Image
  1. product detail page also looks broken on mobile
Image
  1. pagination on mobile is also broken
Image
  1. fix linter warnings

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, check next:

  1. Seems like bad alignment of bread crumbs:
{079CA93A-7619-4D29-8BCF-E4C159CB826D}
  1. If I select something in You may also like section the page should scroll me to the top.

  2. All links should refer to proper existing resourses:

{C3CF1B02-EE95-40D0-86F5-98BAC4F7605E}

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from previous review were not fixed.

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants