Conversation
brespect
left a comment
There was a problem hiding this comment.
Good progress, lets check next:
- Add the space between size selectors and error message.
- The hover effect should not overflow the another image:
- All links should be proper reference to existing resourses:
- The hover effect of this card, merge with the main backgorund, fix this:
- Thiss button is too small, check the mockup:
- If you select something in this section the page should smoothly scrolls to top, remove the loader:
-
Add favicon.
-
The header should take up the entire width of the screen.
- These active effects should look different according to the Figma Mockup.
|
Hi! I've fixed all the issues from your review. |
|
Hi! I've fixed issues 2 and 3 from your latest review. Regarding the 'Brand new models' section — after checking the data in public/api/products.json, I found that all products include both a full price and a discounted price, meaning there are no products without a discount in the dataset. To handle this as best as possible, I've updated the filtering logic to:
Let me know if you'd like a different approach! |
brespect
left a comment
There was a problem hiding this comment.
Hi! Thanks for the update and for checking the dataset.
For the "Brand new models" section, the discount logic actually shouldn’t be used.
Even if the API contains both price and fullPrice, in this section we should display only the regular (actual) price on the cards and not show the discount or the crossed-out price.
So the filtering by discount isn’t needed here — just render the products and display the current price only.
Thanks!
|
Hi! Fixed the 'Brand new models' section — products are now filtered by the most recent year only, and cards display the regular price without any discount or crossed-out price. |



Live Demo