Skip to content

Develop#931

Open
KazymyrYan wants to merge 12 commits intomate-academy:masterfrom
KazymyrYan:develop
Open

Develop#931
KazymyrYan wants to merge 12 commits intomate-academy:masterfrom
KazymyrYan:develop

Conversation

@KazymyrYan
Copy link

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, lets check next:

  1. Add the space between size selectors and error message.
Image
  1. The hover effect should not overflow the another image:
Image
  1. All links should be proper reference to existing resourses:
Image
  1. The hover effect of this card, merge with the main backgorund, fix this:
Image
  1. Thiss button is too small, check the mockup:
Image
  1. If you select something in this section the page should smoothly scrolls to top, remove the loader:
Image
  1. Add favicon.

  2. The header should take up the entire width of the screen.

Image
  1. These active effects should look different according to the Figma Mockup.
Image

@KazymyrYan
Copy link
Author

Hi! I've fixed all the issues from your review.

@KazymyrYan KazymyrYan requested a review from brespect March 11, 2026 19:19
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. products in this section should not be discounted
Image
  1. it would be useful to have the option to remove a product from the cart after pressing the button again
Image
  1. increase the price here as well
Image

@KazymyrYan
Copy link
Author

KazymyrYan commented Mar 11, 2026

Hi! I've fixed issues 2 and 3 from your latest review.

Regarding the 'Brand new models' section — after checking the data in public/api/products.json, I found that all products include both a full price and a discounted price, meaning there are no products without a discount in the dataset.

To handle this as best as possible, I've updated the filtering logic to:

  1. Only include products from the most recent year
  2. Sort them by discount amount (ascending), so products with the smallest discount appear first

Let me know if you'd like a different approach!

@KazymyrYan KazymyrYan requested a review from etojeDenys March 11, 2026 20:59
Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the update and for checking the dataset.

For the "Brand new models" section, the discount logic actually shouldn’t be used.
Even if the API contains both price and fullPrice, in this section we should display only the regular (actual) price on the cards and not show the discount or the crossed-out price.

So the filtering by discount isn’t needed here — just render the products and display the current price only.

Thanks!

@KazymyrYan
Copy link
Author

Hi! Fixed the 'Brand new models' section — products are now filtered by the most recent year only, and cards display the regular price without any discount or crossed-out price.

@KazymyrYan KazymyrYan requested a review from brespect March 12, 2026 17:57
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants