[CollapsingToolbarLayout] Exposes title textAlignment property #1186
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
| int id = a.getInt( | ||
| R.styleable.CollapsingToolbarLayout_titleTextAlignment, 0); | ||
| Alignment alignment = Alignment.values()[id]; | ||
| collapsingTextHelper.setTextAlignment(alignment); |
There was a problem hiding this comment.
setExpandedTitleTextAlignment(alignment);
| if (a.hasValue(R.styleable.CollapsingToolbarLayout_titleTextAlignment)) { | ||
| int id = a.getInt( | ||
| R.styleable.CollapsingToolbarLayout_titleTextAlignment, 0); | ||
| Alignment alignment = Alignment.values()[id]; |
There was a problem hiding this comment.
It's better to explicitly create a conversion method here to prevent the dependency on enum orders, which can be fragile.
| @@ -190,6 +190,16 @@ | |||
| <flag name="end" value="0x00800005"/> | |||
| </attr> | |||
|
|
|||
| <!-- The alignment of the title text. --> | |||
There was a problem hiding this comment.
Add a description to explain that the value here should be corresponding to the enum android.text.Layout.Alignment.
Thanks for starting a pull request on Material Components!
Don't forget:
[Buttons] Updated documentationcloses #1234Contributing
has more information and tips for a great pull request.