[TextInputLayout] set the endIconOnClickListener also with endIconMode #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gabrielemariotti, |
drchen
reviewed
Jul 23, 2021
| @@ -380,6 +380,7 @@ | |||
| @Nullable private Drawable endDummyDrawable; | |||
| private int endDummyDrawableWidth; | |||
| private Drawable originalEditTextEndDrawable; | |||
| protected OnClickListener endIconOnClickListener; | |||
There was a problem hiding this comment.
Why do we need this and where is it being used?
There was a problem hiding this comment.
It is used in the EndIconDelegate#callOriginalEndIconOnClickListener method.
drchen
requested changes
Jul 23, 2021
| @@ -3056,6 +3057,13 @@ public int getEndIconMode() { | |||
| * will have | |||
| */ | |||
| public void setEndIconOnClickListener(@Nullable OnClickListener endIconOnClickListener) { | |||
| this.endIconOnClickListener = endIconOnClickListener; | |||
| if (getEndIconMode() == END_ICON_NONE || getEndIconMode() == END_ICON_CUSTOM) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
endIconModeoverrides theendIconOnClickListener.With this change it is possible to add an
endIconOnClickListeneralso when theendIconModeis set.The listener is called after the
onClickListenerdefined in theEndIconDelegate.It can close #919 and #1272