Skip to content

[Snackbar] bugfix: setting layoutParams for snackbarLayout Open #1076 #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cchencool
Copy link

Solve issue:[Setting LayoutParams for SnackbarLayout doesn't work bug]
#1076

Reason: BaseTransientBottomBar#updateMargins ignored the original layoutParams in the view and simply cover it with a new value.

…rial-components#1076`

Solve issue:[Setting LayoutParams for SnackbarLayout doesn't work bug]
material-components#1076

Reason: BaseTransientBottomBar#updateMargins ignored the original layoutParams in the view and simply cover it with a new value.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@cchencool
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 7, 2020
marginParams.bottomMargin = originalMargins.bottom + extraBottomMargin;
marginParams.leftMargin = originalMargins.left + extraLeftMarginWindowInset;
marginParams.rightMargin = originalMargins.right + extraRightMarginWindowInset;
marginParams.bottomMargin += originalMargins.bottom + extraBottomMargin;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the margins when they are set via XMLs.

I think the correct fix will be overriding setLayoutParams() method and set originalMargins there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants