[BadgeDrawable] Added shape customizations #1640
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was there any update on the design feedback for this? |
DoruAdryan
approved these changes
Jul 20, 2021
DoruAdryan
reviewed
Jul 20, 2021
DoruAdryan
reviewed
Jul 20, 2021
|
Any progress? |
|
when can we expect changes? |
|
Any updates on this? Possibility of adding a stroke to a badge would be highly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some features to the
BadgeDrawable:shapeAppearance/shapeAppearanceOverlayin the badge style to customize the shape of the badge:badgeRadius/badgeWithTextRadiusto customize the badge radius(or size):badgeStrokeColor/badgeStrokeWidthto customize the badge strokeIt preserves the current default behavior.
It can close #1200, #826.