Skip to content

[MaterialCardView] Update material card view to support shapeAppearanceOverlay without content clipping #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yogeshpaliyal
Copy link

@yogeshpaliyal yogeshpaliyal commented Dec 23, 2020

…ontent clipping

Thanks for starting a pull request on Material Components!

Don't forget:

  • Identify the component the PR relates to in brackets in the title.
    [Buttons] Updated documentation
  • Link to GitHub issues it solves. closes #1950
  • Sign the CLA bot. You can do this once the pull request is opened.

Contributing
has more information and tips for a great pull request.

@google-cla
Copy link

google-cla bot commented Dec 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 23, 2020
@yogeshpaliyal
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 23, 2020
@yogeshpaliyal yogeshpaliyal changed the title Close #1950 Update material card view to support shapeAppearanceOverlay without content clipping [MaterialCardView] Close #1950 Update material card view to support shapeAppearanceOverlay without content clipping Feb 16, 2021
@yogeshpaliyal yogeshpaliyal changed the title [MaterialCardView] Close #1950 Update material card view to support shapeAppearanceOverlay without content clipping [MaterialCardView] Update material card view to support shapeAppearanceOverlay without content clipping Feb 16, 2021
@yogeshpaliyal yogeshpaliyal requested a review from drchen August 23, 2021 05:01
@yogeshpaliyal
Copy link
Author

@MenaKing2020 didn't get it?

@@ -119,6 +128,12 @@ public MaterialCardView(Context context, AttributeSet attrs, int defStyleAttr) {
isParentCardViewDoneInitializing = true;
// Ensure we are using the correctly themed context rather than the context that was passed in.
context = getContext();
shapeAppearance = ShapeAppearanceModel.builder(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be removed. And in onSizeChanged(), call getShapeAppearanceModel() instead.

Also, I think we have a bug that when ShapeAppearanceModel is set from XMLs, setClipToOutline() is not correctly called. We should fix that issue, and make your change only applied on API < 21.

@drchen
Copy link
Contributor

drchen commented Oct 13, 2021

@MenaKing2020 didn't get it?

You will need approval from Material team. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants