-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[MaterialCardView] Update material card view to support shapeAppearanceOverlay without content clipping #1951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@MenaKing2020 didn't get it? |
@@ -119,6 +128,12 @@ public MaterialCardView(Context context, AttributeSet attrs, int defStyleAttr) { | |||
isParentCardViewDoneInitializing = true; | |||
// Ensure we are using the correctly themed context rather than the context that was passed in. | |||
context = getContext(); | |||
shapeAppearance = ShapeAppearanceModel.builder( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be removed. And in onSizeChanged(), call getShapeAppearanceModel() instead.
Also, I think we have a bug that when ShapeAppearanceModel is set from XMLs, setClipToOutline() is not correctly called. We should fix that issue, and make your change only applied on API < 21.
You will need approval from Material team. : ) |
…ontent clipping
Thanks for starting a pull request on Material Components!
Don't forget:
[Buttons] Updated documentation
closes #1950
Contributing
has more information and tips for a great pull request.