Support ViewPager in BottomSheet #2188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix swipe gestures
drchen
reviewed
Jul 13, 2021
| return view; | ||
| } | ||
| if (view instanceof ViewPager2) { | ||
| ViewPager2 viewPager2 = (ViewPager2) view; |
There was a problem hiding this comment.
No need to declare a separate local variable.
| @@ -1286,12 +1288,32 @@ boolean shouldHide(@NonNull View child, float yvel) { | |||
| return Math.abs(newTop - collapsedOffset) / (float) peek > HIDE_THRESHOLD; | |||
| } | |||
|
|
|||
| @Nullable | |||
| private View getCurrentViewWithVP2(ViewPager2 viewPager) { | |||
There was a problem hiding this comment.
getCurrentViewFromViewPager?
slavonnet
suggested changes
Aug 4, 2021
| if(((RecyclerView) child).getLayoutManager() == null) | ||
| return null; | ||
| child = ((RecyclerView) child).getLayoutManager().findViewByPosition(currentItem); | ||
| } |
| @@ -65,6 +65,8 @@ | |||
| import com.google.android.material.resources.MaterialResources; | |||
| import com.google.android.material.shape.MaterialShapeDrawable; | |||
| import com.google.android.material.shape.ShapeAppearanceModel; | |||
| import androidx.recyclerview.widget.RecyclerView; | |||
| import androidx.viewpager2.widget.ViewPager2; | |||
There was a problem hiding this comment.
Why need dependency to ViewPager2? This code may be applied to any ViewGroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix swipe gestures
Thanks for starting a pull request on Material Components!
Don't forget:
[Buttons] Updated documentationcloses #1234Contributing
has more information and tips for a great pull request.