[MaterialDatePicker] Adding an optional 'Clear' button #3145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DvTonder
force-pushed
the
clear_button
branch
3 times, most recently
from
8f974db to
0141fc4
Compare
DvTonder
force-pushed
the
clear_button
branch
4 times, most recently
from
a3dee3f to
881ddef
Compare
Author
|
I have updated the full screen date picker to support the clear function |
drchen
previously approved these changes
Apr 24, 2023
drchen
added
the
Reviewing Internally
Contributor
|
Can you rebase your cl on the head of the repository? There seems some merge problem when I pulled it for our internal review. |
Author
|
It was a bit messy with a force push but I managed to rebase to the HEAD. Should be good now |
Contributor
|
It seems working now. Thank you! : ) |
DvTonder
force-pushed
the
clear_button
branch
2 times, most recently
from
c730ab2 to
56c0806
Compare
2 tasks
DvTonder
force-pushed
the
clear_button
branch
from
404eec7 to
3cf2d1a
Compare
DvTonder
force-pushed
the
clear_button
branch
from
0af7a5f to
c04470c
Compare
DvTonder
force-pushed
the
clear_button
branch
from
7f55925 to
acddaf7
Compare
Contributor
|
Hey Hunter, I think the issue we've run into here is that in certain layouts we were not sure where to put the "clear" button. Will you able to have someone to take a look or check if designers have any thoughts? |
…emove the selected date with the option to calling a clear listener and dismissing the dialog when clicked. Supports both dialog and full screen mode
…. 'Clear') The design suggestion is following the spec here: https://m3.material.io/components/date-pickers/specs#f25f68b7-1bb5-4248-829e-fe3cd3499dab And adding only the clear button to the bottom button bar
…emove the selected date with the option to calling a clear listener and dismissing the dialog when clicked. Supports both dialog and full screen mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an optional 'Clear' button that can be used to remove the selected date with the option to calling a clear listener and dismissing the dialog when clicked.
closes #1332
Note: This is the same code as previously submitted as a pull request but it has been rebased against the latest codebase as of 18 December 2022