Skip to content

[TabLayout] (proposal) ripple #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manabu-nakamura
Copy link
Contributor

@manabu-nakamura manabu-nakamura commented Sep 15, 2024

closes #3157
(before) circle with top and bottom cut off?
Screenshot_20240921_194448
(after) rounded rectangle
Screenshot_20240921_193738
(before) circle with top and bottom cut off?
Screenshot_20240910_183906
(after) rounded rectangle
Screenshot_20240921_193829

@imhappi
Copy link
Contributor

imhappi commented Nov 26, 2024

Reached out to our designers on what the ripple should look like for TabLayout

@manabu-nakamura
Copy link
Contributor Author

manabu-nakamura commented Dec 10, 2024

Reached out to our designers on what the ripple should look like for TabLayout

d68ebbe and 5dfed19: Did the ripple effect become correct? If so, please update the movies in https://m3.material.io/components/tabs/guidelines, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TabLayout] ripple of TabLayout is different from ripple of other components
2 participants