Skip to content

[Bottomsheet] draw under navbar #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hrach
Copy link
Contributor

@hrach hrach commented Jan 8, 2020

This PR fixes:

  • lib: drawing bottomsheet content under navbar;
  • catalog: reseting layout height in catalog demo app;
  • catalog: dynamic setting of light navbar for bottomsheet; if it would be done declaratively, it's ok.

Note: the demo uses statically defined 400px peek height, which is not much convenient.

Preview

device-2020-01-08-114710

device-2020-01-08-125430

@hrach
Copy link
Contributor Author

hrach commented Jan 8, 2020

A workaround we currently use in our BottomSheetDialogFragments:

    override fun onActivityCreated(savedInstanceState: Bundle?) {
        super.onActivityCreated(savedInstanceState)
        dialog?.findViewById<View>(R.id.container)?.fitsSystemWindows = false
        dialog?.findViewById<View>(R.id.design_bottom_sheet)?.fitsSystemWindows = true
    }

@melaniegoetz melaniegoetz self-assigned this Jan 10, 2020
@melaniegoetz
Copy link
Contributor

Hey there, thanks for contributing with this PR! 🎉
We already have a similar fix in the works (that will encompass parts 1 & 2 of these changes). That will released to github soon, and once it is, then we can accept a PR for part 3 (catalog: dynamic setting of light navbar for bottomsheet; if it would be done declaratively, it's ok). Thank you!

@hrach
Copy link
Contributor Author

hrach commented May 6, 2020

Hi guys, any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants