Skip to content
This repository was archived by the owner on Oct 14, 2021. It is now read-only.

Swift4.1 & Xcode9.3#10

Open
yoching wants to merge 8 commits intomaterial-motion:developfrom
yoching:swift4
Open

Swift4.1 & Xcode9.3#10
yoching wants to merge 8 commits intomaterial-motion:developfrom
yoching:swift4

Conversation

@yoching
Copy link

@yoching yoching commented Apr 13, 2018

Hi!
Updated project for swift4.1 & Xcode 9.3.

Thank you😀

@appsforartists appsforartists requested a review from jverkoey April 13, 2018 23:02
@appsforartists
Copy link
Member

Thanks!

Looks like the build is broken. I'm not an iOS engineer, but can you please take a look at that?

@yoching
Copy link
Author

yoching commented Apr 18, 2018

I updated the configurations but I couldn't remove the error.
It seems that it is relating to arcanist.
Do you know anything about this configuration?

@appsforartists
Copy link
Member

Unfortunately, @jverkoey is a bit busy this month, and he's our Apple maintainer. I don't know enough about that setup to be of much help. I'm sure he'll be happy to help when he has time, but that could be a few weeks.

One option would be to install arc, test a clean checkout, and then incrementally add your changes until you find the problem. For instance, I notice that you removed the quotes in the podfile. Could that be the source of the issue?

You can install arc with mdm tools or by following their install guide.

}

let motionStream = MotionObservable<Int> { observer in
_ = MotionObservable<Int> { observer in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like stylistic changes. Do you need to touch this file to perform the upgrade?

observer.next(false, value)
observer.next(true, value)
observer.next((false, value))
observer.next((true, value))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change required to upgrade?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants