docs: use units_GPa in ElasticityCalc examples - #243
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
pre-commit.ci run |
pre-commit.ci runners lack outbound network for nodeenv's Node.js download, causing the pyright hook to fail with a DNS resolution error. The pyright[nodejs] extra ships a prebuilt Node binary, avoiding the runtime download. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pre-commit.ci disables outbound network during hook execution, but the pyright hook fetches the pyright npm package at runtime, so it can never pass there. Skip it on pre-commit.ci; it still runs locally and mypy is the CI typechecker of record. Reverts the prior pyright[nodejs] attempt, which only addressed the node binary download. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
+ Coverage 93.13% 93.18% +0.04%
==========================================
Files 26 26
Lines 1865 1864 -1
==========================================
Hits 1737 1737
+ Misses 128 127 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates README and notebook usage examples to use the new
units_GPaoption onElasticityCalcinstead of manual eV/ų→GPa conversion.Changes
units_GPa=Trueand drops the manual* 160.2176621conversion (props['bulk_modulus_vrh']is already in GPa).units_GPa=Trueconverts (elastic_tensor,bulk_modulus_vrh,shear_modulus_vrh,youngs_modulus,residuals_sum), and the_unitsoutput entry.units_GPa=Trueto itsElasticityCalc.ChainedCalckey-demo) now passesunits_GPa=Truefor consistency with the parallel run later in the notebook.No source/docstring changes needed —
ElasticityCalcalready documentsunits_GPa.🤖 Generated with Claude Code