Canged from imperative to declarative apply of flutters gradle plugin #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and bumped versions in example
Owner
|
hey there, thanks for spotting this! Looks good to me but I have one question; would this require updating the minimum compatible version of the sdk (the value for environment.sdk) ? Looking at the migration guide it does not look like there's a need to to so, but I might have missed something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading the example to test today, I saw that the example was using imperative apply of flutters grade plugins, which is being deprecated. I followed Flutter's guide on how to manually migrate here .
I also had to bump some versions.
Compiles and runs fine on: