Skip to content

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Apr 24, 2025

Motivation for this change

@zstone1

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.11.0 milestone Apr 24, 2025
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Apr 24, 2025
@affeldt-aist affeldt-aist modified the milestones: 1.11.0, 1.12.0 May 1, 2025
@affeldt-aist
Copy link
Member Author

affeldt-aist commented May 9, 2025

@zstone1 could this be the first step towards addressing issue #1437 ?
This PR introduces a definition of metric space, move the lemma cvg_nbhsP from realfun.v to the directory topology_theory, incidentally together with at_left/at_right, which are now easier to move that normedtype.v has been split and reordered.

I propose to generalize a few more lemmas in the same manner, eventually moving a few things from normedtype_theory to topology_theory, so that we can arrive at a minimal PR introducing the metric structure without much disturbance for users. A complete generalization work can be carried incrementally. I am afraid that doing all the generalizations as a condition for merging will create a monster PR.

Copy link
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One should add a factory with just the metric (with the triangular inequality) that builds balls from there.

@zstone1
Copy link
Contributor

zstone1 commented Nov 27, 2025

Makes sense to add this. I'll note that there are a handful of places (itll take me a minute to find them all) where we use pseudometric + hausdorff instead of this. Might be nice for a followup PR to add a factory for hausdorff + pseudometric => metric too, and upgrade those places.

@affeldt-aist
Copy link
Member Author

Many thanks for the comments, I should be able to address them later this week.

@affeldt-aist
Copy link
Member Author

affeldt-aist commented Dec 9, 2025

One should add a factory with just the metric (with the triangular inequality) that builds balls from there.

I have added this factory. 118c342

Might be nice for a followup PR to add a factory for hausdorff + pseudometric => metric too, and upgrade those places.

I couldn't figure it right away so we can maybe postpone to the next release (I'll create an issue about it to remember it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants