Skip to content

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Dec 3, 2025

Co-author: holgerthies

fixes #1781

Motivation for this change
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist
Copy link
Member Author

affeldt-aist commented Dec 3, 2025

@zstone1 we observed that we can preserve the correct pretty-printing of the notation {within _, continuous _} by protecting the type constraint with a definition

do you think this could be an appropriate solution to fix issue #758 ?

fyi: @CohenCyril

@CohenCyril
Copy link
Member

The problem with this notation is that it is not compositional, there are many reasons why f could have domain a subspace topology, and not have been tagged with from_subspace. However it does preserve the notation `{within ...} if you typed it in the first place, so it is still an improvement. I will work on a more general solution based on displays at some point, meanwhile this is a strict improvement.

@affeldt-aist
Copy link
Member Author

I understand that this is only a temporary and partial solution. I'll complete the PR asap.

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Dec 3, 2025
@affeldt-aist affeldt-aist marked this pull request as draft December 3, 2025 14:25
@affeldt-aist affeldt-aist added this to the 1.15.0 milestone Dec 3, 2025
@affeldt-aist affeldt-aist marked this pull request as ready for review December 4, 2025 04:20
@affeldt-aist
Copy link
Member Author

@CohenCyril I have added a comment in the documentation to make it clear that the mechanism is a temporary, partial solution. Ok to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

{within _, continuous _} notation is not documented

2 participants