Fix bug in Collector with Graph data #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilippoOlivo
force-pushed
the
0.2Data
branch
4 times, most recently
from
f32d7e4 to
6f52c79
Compare
FilippoOlivo
force-pushed
the
0.2Data
branch
9 times, most recently
from
6c66cf6 to
f32af3c
Compare
dario-coscia
requested changes
Feb 19, 2025
pina/utils.py
Outdated
| @@ -48,7 +48,8 @@ def labelize_forward(forward, input_variables, output_variables): | |||
| :type output_variables: list[str] | tuple[str] | |||
| """ | |||
| def wrapper(x): | |||
| x = x.extract(input_variables) | |||
| if isinstance(x, LabelTensor): | |||
There was a problem hiding this comment.
why this? This method should not check the instance since it is applied only when use_lt is true in the solver. Please remove it.
There was a problem hiding this comment.
If we use graphs x is a Batch object. It is necessary if I want to use graphs and LabelTensors together
There was a problem hiding this comment.
I still don't see the point. In the solver do you set use_lt to true?
dario-coscia
added
pr-to-fix
dario-coscia
requested changes
Feb 19, 2025
pina/utils.py
Outdated
| @@ -48,7 +48,8 @@ def labelize_forward(forward, input_variables, output_variables): | |||
| :type output_variables: list[str] | tuple[str] | |||
| """ | |||
| def wrapper(x): | |||
| x = x.extract(input_variables) | |||
| if isinstance(x, LabelTensor): | |||
There was a problem hiding this comment.
I still don't see the point. In the solver do you set use_lt to true?
FilippoOlivo
force-pushed
the
0.2Data
branch
from
f32af3c to
78bedd0
Compare
FilippoOlivo
force-pushed
the
0.2Data
branch
from
78bedd0 to
a919d06
Compare
dario-coscia
approved these changes
Feb 19, 2025
FilippoOlivo
force-pushed
the
0.2Data
branch
from
a919d06 to
37d61ea
Compare
FilippoOlivo
added
v0.2
ndem0
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix some bugs with solvers and Graphs