Skip to content

Conversation

@manojponnusamy2032-star
Copy link

@manojponnusamy2032-star manojponnusamy2032-star commented Dec 13, 2025

Fixes #1321

Technical details

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

…n#1843)

- Add delete() method to RecordStore to call the delete API
- Add delete button to RecordPageContent with confirmation dialog
- Check DELETE privilege before allowing deletion
- Navigate back to table page after successful deletion
- Show success/error toast notifications
…olumn

- Backend: Add validation in columns.patch() to reject rename attempts on the default Mathesar-added PK column
- Frontend: Improve error handling to capture and display backend validation error details
- Minimal change: 2 files, 15 insertions
…olumn - fix import order for linter compliance
…ax schema USAGE checks for table-level SELECT privilege
@manojponnusamy2032-star manojponnusamy2032-star force-pushed the fix/backend-orderable-columns-1321 branch 3 times, most recently from 863b27a to 572f71f Compare December 13, 2025 12:08
Exclude non-orderable types from ORDER BY clauses to prevent SQL errors.

Use pg_opclass and pg_am to reliably detect B-tree orderable columns.

Raise a deterministic error if no orderable columns exist.

Signed-off-by: manojponnusamy2032-star <[email protected]>
@manojponnusamy2032-star manojponnusamy2032-star force-pushed the fix/backend-orderable-columns-1321 branch from 572f71f to eeafebf Compare December 13, 2025 12:21
@Anish9901
Copy link
Member

Hey @manojponnusamy2032-star, Please fix the tests and open a new PR.

@Anish9901 Anish9901 closed this Dec 16, 2025
@manojponnusamy2032-star manojponnusamy2032-star deleted the fix/backend-orderable-columns-1321 branch December 18, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to load records with circle column type

2 participants