Release 1.1.1#8
Merged
Merged
Conversation
Cause: a `DeviceInstallations` instance was being created and added to the return vector even if no packages matched. Fix: skip the device if no packages match. Other changes: initialize the packages vector with the known capacity. Closes #7.
According to the following rules: - Keep functions that are strongly tied to a type inside its `impl` block. - Within a module, declare the following in order: - `use` declarations. - Module-level constants / statics. - Type aliases. - For each type: - Type definition. - Inherent `impl` block - Trait `impl` blocks for that type. - Loose functions that are either not strongly tied to a type, or used by multiple types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External changes
Internal changes