-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Anki integration with Jisho.org and more #49
base: main
Are you sure you want to change the base?
Conversation
This makes it so that the most common definition is the one that will be shown in the anki card. Other definitions will be ignored.
Return jisho entries in an API compatible format to the existing look_up method
…sho entries - Store them in separate objects in order to access unique keys easily
- Add prioritizedTags array to further prioritize specific tags
I'm fine with adding options to allow online dictionaries, but can you explain the motivation for preferring that as the default over a local dictionary? Also, there are way too many commits for this one PR, many of which seemingly unrelated to the core function of adding jisho aoi, for example, function refactors, and moving logic to files. It would be great if you can break up those changes to separate PRs. |
So the way I came about this was that I wanted to use JMDict Extra to match my yomichan dictionary but the I agree about the long PR I got carried away trying to make things work like I wanted to on my end that I forgot to break it down into parts. I'll look into making separate PRs. |
Updates the existing Anki integration with more fields in order to create more detailed cards that include translations, more definitions, sound search improvements, etc. I've included a sample Anki deck which I've been using with this implementation.
Changes
logs.js
file into a newankicard.js
file.extractOtherForms
.