Bugfix for #18 #32
Open
Bugfix for #18 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in mathnet#18 there is now additional parameter in FirCoefficients that is missing here. For compatibility reasons I have set Gain to 1.
ldlc100
reviewed
Dec 19, 2024
| if (mode == ImpulseResponse.Finite) | ||
| { | ||
| double[] c = FirCoefficients.LowPass(sampleRate, cutoffRate, order >> 1); | ||
| double[] c = FirCoefficients.LowPass(sampleRate, cutoffRate, 1, order >> 1); |
There was a problem hiding this comment.
Would FirCoefficients.LowPass(sampleRate, cutoffRate, halforder: order >> 1) be preferred here since the issue here is not specifying what keyword order >> 1 goes to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #18 there is now additional parameter in FirCoefficients that is missing here. For compatibility reasons I have set Gain to 1.