[896] Restore Popout content for blocked popouts and emit onDidBlockPopout event #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 86e8e63:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you restore a stored layout from JSON that includes a popout on page load, most browser will block it from opening since the user didn't initiate opening the new popup window. Currently it is hard to determine if this happens and to handle it so that pop out content isn't lost.
This adds an event that triggers if the popout fails to open because of window.open failing to return a window object (most likely blocked by browsers popup blocker) and it also adds the popout group back into grid in the same way as if you would have closed the popout window manually. Hopefully this makes sense.
This is my suggestion for how to improve the behaviour when the browsers blocks the popout from opening and I'm happy to create some settings/props to make it optional.
Todo